Add PR preview pruning and retention management#378
Conversation
|
🚀 Preview deployment: https://layer5io.github.io/getnighthawk/pr-preview/pr-378/
|
|
Hi maintainers 👋 |
Signed-off-by: l5io <ci@layer5.io> Signed-off-by: Yashi Singhal285 <yashi.singhal410@gmail.com>
Signed-off-by: Yashi Singhal285 <yashi.singhal410@gmail.com>
Yashisinghal285
force-pushed
the
issue-377-preview-pruning
branch
from
831bd43 to
2732b56
Compare
|
Hi maintainers 👋 I noticed the failing This PR only modifies Please let me know if you'd like any changes from my side or if there is anything else I can help investigate. Thanks! 🙌 |
| <center><h1>301 Moved Permanently</h1></center> | ||
| <hr><center>cloudflare</center> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
What is use of changing this file.
There was a problem hiding this comment.
@Bhumikagarggg Thanks for pointing this out. This file wasn't intentionally modified as part of the preview pruning feature. It changed while I updated my branch and resolved the merge conflict with the latest master. The functional changes for this PR are only in build-and-preview-site.yml.
|
I approved this PR by mistake. |
|
|
||
| jobs: | ||
| build-and-deploy-preview: | ||
| outputs: |
There was a problem hiding this comment.
Please move output section after runs-on
There was a problem hiding this comment.
@Bhumikagarggg Done, thank you for the suggestion. I've moved the outputs section below runs-on as requested. Could you please take another look when you have a chance?
|
|
||
| git add pr-preview | ||
| git commit -m "Prune old PR previews" || true | ||
| git push || true |
There was a problem hiding this comment.
Replace git push || true with git push instead of ignoring push failures.
|
@Sbragul26 Thanks for the review! I've updated the workflow by replacing |
| git config user.email "github-actions[bot]@users.noreply.github.com" | ||
|
|
||
| git add pr-preview | ||
| git commit -m "Prune old PR previews" || true |
There was a problem hiding this comment.
For this too replace git commit -m "Prune old PR previews" with this.
There was a problem hiding this comment.
Thanks for the review! I've removed || true from the git commit command since the workflow already checks for staged changes before attempting the commit.
4 participants
Description
This PR adds preview pruning and retention management for PR preview deployments.
What changed
pr-preview/pr-*directoriesIssue
Fixes #377
Notes for Reviewers
pr-previewdirectory is modifiedChecklist
Signed commits